Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Submitting pipelines on eicweb for pull requests from forks #40

Open
wdconinc opened this issue Aug 6, 2022 · 0 comments
Labels
enhancement New feature or request topic: infrastructure Regarding build system, CI, CD

Comments

@wdconinc
Copy link
Contributor

wdconinc commented Aug 6, 2022

OT but for PRs from forks we could direct users to eicweb where they should submit a pipeline by hand (cumbersome) or write a bot to submit the pipeline when instructed by a comment from a member of epic-devs or epic-admins.

Originally posted by @wdconinc in #39 (comment)

@veprbl veprbl added the enhancement New feature or request label Aug 6, 2022
@veprbl veprbl added the topic: infrastructure Regarding build system, CI, CD label Oct 1, 2022
wdconinc pushed a commit that referenced this issue Nov 4, 2022
### Briefly, what does this PR introduce?
Make build module function in B0 ecal static so that it doesn't get
picked up by other elements

### What kind of change does this PR introduce?
- [X] Bug fix (issue #40)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [X] Tests for the changes have been added
- [X] Documentation has been added / updated
- [X] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No
### Does this PR change default behavior?
No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

No branches or pull requests

2 participants