Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: use EPIC_ECCE_LEGACY_COMPAT=OFF #107

Merged
merged 1 commit into from Sep 10, 2022
Merged

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Sep 9, 2022

Ideally, there would have been a warning message for users living with EPIC_ECCE_LEGACY_COMPAT=ON. But since many are only now learning things through the tutorials it makes sense to drop ECCE ASAP and reduce the confusion.

Briefly, what does this PR introduce?

A small follow up to yesterday's tutorial session. This removes unnecessary symlinks for users that are now just learning things.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

Supposedly, yes.

Ideally, there would have been a warning message for users living with
EPIC_ECCE_LEGACY_COMPAT=ON. But since many are only now learning
things through the tutorials it makes sense to drop ECCE ASAP and
reduce the confusion.
@veprbl veprbl requested a review from wdconinc September 9, 2022 21:22
@wdconinc wdconinc enabled auto-merge (squash) September 9, 2022 21:24
@veprbl
Copy link
Member Author

veprbl commented Sep 9, 2022

-------- WWWW ------- G4Exception-START -------- WWWW -------
*** G4Exception : GeomVol1002
      issued by : G4PVPlacement::CheckOverlaps()
Overlap with volume already placed !
          Overlap is detected for volume AV_586!InnerMPGDBarrel_Mod1_88#88!component1_1#1:90 (G4Box)
          apparently fully encapsulating volume AV_585!InnerMPGDBarrel_Mod1_87#87!component0_0#0:88 (G4Box) at the same level!
NOTE: Reached maximum fixed number -1- of overlaps reports for this volume !
*** This is just a warning message. ***
-------- WWWW -------- G4Exception-END --------- WWWW -------

Is this supposed to happen, or issue-worthy?

@wdconinc
Copy link
Contributor

wdconinc commented Sep 9, 2022

It's issue worthy, @mposik1983 . It was probably always there but has shown up irregularly since we went to geant4 11.

@wdconinc wdconinc merged commit 5e79d13 into main Sep 10, 2022
@wdconinc wdconinc deleted the pr/cmake_disable_ecce_default branch September 10, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants