Adjust the length of BIC according to the newest baseline #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: barrel
wdconinc
reviewed
Feb 29, 2024
wdconinc
previously approved these changes
Mar 1, 2024
mariakzurek
dismissed
wdconinc’s stale review
The merge-base changed after approval.
wdconinc
previously approved these changes
Mar 1, 2024
mariakzurek
dismissed
wdconinc’s stale review
The merge-base changed after approval.
wdconinc
previously approved these changes
Mar 3, 2024
mariakzurek
dismissed
wdconinc’s stale review
The merge-base changed after approval.
wdconinc
previously approved these changes
Mar 3, 2024
wdconinc
previously approved these changes
Mar 3, 2024
wdconinc
force-pushed
the
bic-adjust-eosb
branch
from
bebf7b8
to
52ebdab
Compare
wdconinc
approved these changes
Mar 3, 2024
|
Strange, didn't let me approve until after I did a command line rebase... Anyway, same diffs in the interlayers file, and the spurious duplicated changes to the FFwd region are gone now. |
wdconinc
force-pushed
the
bic-adjust-eosb
branch
from
52ebdab
to
3d3cf57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Updated dimensions of the Barrel ECal:
Length w/o EoSB (end of sector box): 436.5 cm
Total length w/ EoSB: 466.5 cm
Length in h-going direction: 215 cm (Sector) + 15 cm (EoSB)
Length in e-going direction: 221.5 cm + 15 cm (EoSB)
Center offset: -38.75 cm
h-going: +176.25 cm
h-going + box: +191.25 cm
e-going: -260.25 cm
e-going + box: -275.25 cm
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
no
Does this PR change default behavior?
yes