fix: export all configs to STEP, use part --level 1 HcalBarrel
#702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
changed the title
part --level 1 HcalBarrelpart --level 1 HcalBarrel
github-actions
bot
added
the
topic: infrastructure
wdconinc
force-pushed
the
npdet-to-step-re-enable-hcal-barrel
branch
from
f1dad25
to
58ab872
Compare
wdconinc
force-pushed
the
npdet-to-step-re-enable-hcal-barrel
branch
from
58ab872
to
b4c8b8c
Compare
|
This now exports all geometries to STEP files without any issues in the pipelines (but meshes are exported as surfaces, not solids, due to limitations in npdet_to_step/occt; fixing that is out of scope here where we only want to remove the no-bhcal exceptional pipeline treatment). |
veprbl
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Due to limitations in npdet_to_step, we disabled the HcalBarrel when exporting to STEP. With npsim 1.4.0, the issue with the HcalBarrel was resolved.
This PR re-enables the HcalBarrel in npdet_to_step conversion, and it simplifies the logic to export all detector configs (for consistency and predictability).
TODO:
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.