Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/generate_prim_file: use POSIX process groups instead of psutil #717

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 29, 2024

psutil is an external package. I'd rather not have to worry about providing it.

@veprbl veprbl requested a review from wdconinc April 29, 2024 00:22
@veprbl veprbl enabled auto-merge April 29, 2024 00:22
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that looks a lot less janky too.

@github-actions github-actions bot added topic: infrastructure Regarding build system, CI, CD topic: barrel Mid-rapidity detectors topic: calorimetry labels Apr 29, 2024
@veprbl veprbl added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit ed8f4cf Apr 29, 2024
109 checks passed
@veprbl veprbl deleted the pr/rm_psutil branch April 29, 2024 06:59
@veprbl veprbl added this to the 24.05.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: barrel Mid-rapidity detectors topic: calorimetry topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants