Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plain dates in start/end parameter #15

Closed
jschaeff opened this issue Jan 10, 2023 · 3 comments
Closed

Allow plain dates in start/end parameter #15

jschaeff opened this issue Jan 10, 2023 · 3 comments

Comments

@jschaeff
Copy link
Collaborator

The query /query?start=2022-06-01 should be accepted. Currently it gives:

BAD REQUEST: invalid value of parameter 'end'
@jschaeff
Copy link
Collaborator Author

Only accept full days in parameter, no time specification.

@vpet98
Copy link
Contributor

vpet98 commented Jan 10, 2023

I made it to accept dates only in format 2022-06 (without day). If it is to accept 2022-06-01 as end date, should it return statistics for the whole month of June or until end of May? It seems kind of ambiguous.

@jschaeff
Copy link
Collaborator Author

Sorry, you're right. It's better to keep it like this (I was too quick)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jschaeff @vpet98