Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

add binding address to listen request #20

Closed
wants to merge 1 commit into from

Conversation

clouds56
Copy link

@clouds56 clouds56 commented Oct 4, 2015

Add listen address option.
The editor auto deleted trailing space.

@eidheim
Copy link
Owner

eidheim commented Oct 4, 2015

Thank you, but you should turn off the option to remove trailing spaces. The commits are impossible to read. Please, if you'd like, you can create a new pull request without the trailing space removal.

@eidheim eidheim closed this Oct 4, 2015
@eidheim
Copy link
Owner

eidheim commented Oct 4, 2015

Also, one could have two constructors, one with address, and one without. This way, the library is backwards compatible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants