Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more than two frames of the same type in v2.4 #619

Closed
rsolorio opened this issue Sep 11, 2023 · 1 comment
Closed

Support more than two frames of the same type in v2.4 #619

rsolorio opened this issue Sep 11, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Projects

Comments

@rsolorio
Copy link

rsolorio commented Sep 11, 2023

I was trying to use the library to save multiple artists and multiple genre frames in compliance with Id3v2.4; although the library suports multiple frames, I found a bug that causes to store only two frames at most.

I'm using the '\' (double backslash) separator to specify multiple values; for instance, if I want to save three genre frames I would do something like this: Genre1\Genre2\Genre3; but this ends up with two frames: Genre1 and Genre2\Genre3.

I think the problem is that the write.textFrame function uses a value.replace to identify and replace the separator; the issue is that the replace only works for the first occurrence in the string; you need to use either replaceAll or a regex to replace all occurrences at once.

@eidoriantan eidoriantan self-assigned this Sep 12, 2023
@eidoriantan eidoriantan added the bug Something isn't working label Sep 12, 2023
eidoriantan added a commit that referenced this issue Sep 12, 2023
@eidoriantan eidoriantan added this to To Do in Project API via automation Sep 12, 2023
@eidoriantan
Copy link
Owner

This issue should be fixed in v3.4.2 release. Thank you for reporting this!

Project API automation moved this from To Do to Done Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Project API
  
Done
Development

No branches or pull requests

2 participants