add sp support for encrypted attributes #16 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to use encrypted attributes in my application and wanted to use this library since its fairly simple, so i added support for it. it requires the xmlsec1 program to be installed because it uses it via sub process. there is a python library for xmlsec but I experienced a lot of difficulties using it and pysaml2 does something similar with xmlsec1 so I thought I'd try it.
I ran into an error where there was a super().init() call to object but it said it didn't take any parameters so i just removed the super call.
I'm not sure what else is required to merge this, I could potentially add a test by generating a request and then using xmlsec1 by hand to encrypt it.