Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security on EiffelActivityTriggeredEvent and EiffelActivityStartedEvent needs to be updated #205

Closed
SantoshNC68 opened this issue Apr 23, 2019 · 4 comments
Labels
protocol All protocol changes protocol-incompat Protocol changes that aren't backwards compatible

Comments

@SantoshNC68
Copy link
Member

Description

The EiffelActivityTriggeredEvent and EiffelActivityStartedEvent contains security that is not updated to Agen Edition.(contains same info as tolouse events).
Need to update the schemas for both the events with latest security.

Motivation

Exemplification

Benefits

Possible Drawbacks

@e-backmark-ericsson
Copy link
Member

Changing these two event types is non backwards compatible. Therefore we need to step the major version of those event schemas. Also, according to the versioning documentation a new release with these updated events should be called 'edition-agen-1' if I read that documentation correctly.

@SantoshNC68
Copy link
Member Author

Ok, so we need to release it with edition-agen-1 tag with the fix to these events.
Would the events have major version like 4.0.0 to these events in that case ?

@e-backmark-ericsson
Copy link
Member

Yes, that's my understanding. I'll create a PR.

@e-backmark-ericsson
Copy link
Member

Solved with PR #206

@magnusbaeck magnusbaeck added protocol All protocol changes protocol-incompat Protocol changes that aren't backwards compatible labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol All protocol changes protocol-incompat Protocol changes that aren't backwards compatible
Projects
None yet
Development

No branches or pull requests

3 participants