Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json keyword misspelled in all ActC yaml files #376

Closed
e-backmark-ericsson opened this issue Dec 20, 2023 · 2 comments · Fixed by #377
Closed

Json keyword misspelled in all ActC yaml files #376

e-backmark-ericsson opened this issue Dec 20, 2023 · 2 comments · Fixed by #377
Assignees
Labels

Comments

@e-backmark-ericsson
Copy link
Member

Description

All versions of yaml files for EiffelActivityCanceledEvent has a misspelling on 'additonalProperties'. It should be 'additionalProperties'.
See for example https://github.com/eiffel-community/eiffel/blob/master/definitions/EiffelActivityCanceledEvent/1.0.0.yml#L47
This results in wrongly generated Json schemas for ActC, see for example: https://github.com/eiffel-community/eiffel/blob/master/schemas/EiffelActivityCanceledEvent/1.0.0.json#L155

Motivation

We need to have syntactically correct json schemas

Exemplification

.

Benefits

We need to have syntactically correct json schemas

Possible Drawbacks

What to do with old versions of this event?

@magnusbaeck
Copy link
Member

Is this something that happened in the conversion of the schemas to the YAML format or has the problem been around forever?

@e-backmark-ericsson
Copy link
Member Author

It was introduced in January 2017 through #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants