Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework sampling API #38

Closed
eigenfoo opened this issue Jan 23, 2020 · 1 comment
Closed

Rework sampling API #38

eigenfoo opened this issue Jan 23, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@eigenfoo
Copy link
Owner

Ideally it would be something like

trace, stats = lmc.sample(
    logp_dlogp_func=logp_dlogp_func,
    size=1,
    draws=1000,
    tune=500,
    step="nuts",
    chains=4,
    cores=1,
    progressbar="notebook"
)

instead of

trace, stats = lmc.sample(
    logp_dlogp_func=logp_dlogp_func,
    size=1,
    draws=1000,
    tune=500,
    step=lmc.NUTS(logp_dlogp_func=logp_dlogp_func, size=1),
    chains=4,
    cores=1,
    progressbar="notebook"
)
@eigenfoo eigenfoo added the enhancement New feature or request label Jan 23, 2020
@eigenfoo eigenfoo added this to the v0.2.0 milestone Jan 23, 2020
@eigenfoo
Copy link
Owner Author

Closed by ea50970.

Note that instead of passing step="nuts", we just allow step=None to be the default, and use the init_nuts function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant