fix: local and exported will never be the same object (rollup/rollup@3ba1511)
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 2 2
Lines 215 215
=======================================
Hits 211 211
Misses 4 4 ☔ View full report in Codecov by Sentry. |
|
👍 I can confirm that rollup 4.9.6 failed the test and this PR fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says, this "breaking" update of upstream make us to change the code of this package in order to keep correctness.
See rollup/rollup@3ba1511#diff-9c5406bcdbe04fd5465cd46ceb57b50f991345832a90c526973bfa0b81d54a0aL369 for specific details.