fix: Add type as label to histograms #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
approved these changes
Jul 6, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Jul 6, 2020
## [1.0.3](v1.0.2...v1.0.3) (2020-07-06) ### Bug Fixes * Add type as label to histograms ([#145](#145)) ([a829a72](a829a72))
|
🎉 This PR is included in version 1.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request handlers can be used between http routes. Ex, the same handlers are used to handle both eik packages and npm packages, the only thing separating them is a
typewhich can bepkgornpmin the URLs and on the file system.This adds a
typelabel on the metrics to all handlers which reflects thetypevalue used to separate this in the URLs and on the file system making it possible to differentiate on this in the metrics.