feat: Use @eik/common to load config in a project #84
Conversation
…e.json BREAKING CHANGE: Use logic in @eik/common to load config from eik.json or package.json
| "semantic-release": "17.3.9", | ||
| "tap": "14.11.0" | ||
| }, | ||
| "dependencies": { | ||
| "@eik/common": "4.0.0-next.4", |
There was a problem hiding this comment.
Wondering if using this version is going to cause any issues? Maybe safer to go with v2 until v4 is released?
There was a problem hiding this comment.
Yeah. I am not 100% sure how to fix this one. Semantic Release did just bump two major version without any good reason. Even reported that as a bug: semantic-release/semantic-release#1809
Any good ideas on how to solve it?
There was a problem hiding this comment.
Perhaps roll the version being used here back to v2 for now?
If you want to fix release of v4 instead of v3 could you manually change the version to v3.0.0-next.1 and then update the dist tag? When releasing v4.0.0-next one would need to manually jump over to 4.0.0-next.5 I assume. Might not be worth it to fix it.
# [3.0.0-next.2](v3.0.0-next.1...v3.0.0-next.2) (2021-03-02) ### Features * Use @eik/common to load config in a project ([#84](#84)) ([371dcda](371dcda)) ### BREAKING CHANGES * Use logic in @eik/common to load config from eik.json or package.json * chore: Adjust for PR comments * chore: Remove extra whitespace Co-authored-by: Trygve Lie <trygve.lie@finn.no>
|
🎉 This PR is included in version 3.0.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [3.0.0](v2.0.4...v3.0.0) (2021-08-13) ### Features * Rename module to @eik/postcss-plugin ([#83](#83)) ([7efa758](7efa758)) * Use @eik/common to load config in a project ([#84](#84)) ([371dcda](371dcda)) ### BREAKING CHANGES * Use logic in @eik/common to load config from eik.json or package.json * chore: Adjust for PR comments * chore: Remove extra whitespace Co-authored-by: Trygve Lie <trygve.lie@finn.no> * Rename module to @eik/postcss-plugin Co-authored-by: Trygve Lie <trygve.lie@finn.no>
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This makes use of the logic found in
@eik/commonto config in a project. This should now align with how the client and other plugins do this.The API surface is also changed. Instead of taking an Import Map as the configuration option it can now take an options object with the following arguments:
pathfor defining an path to aeik.jsonother than in the root of the projecturlsfor defining URLs to custom Import Maps. If a Import Map rule exist in both the config and in a Import Map defined throughurls, the rule defined inurlstake precedence.mapsfor defining custom Import Maps as objects. If a Import Map rule exist in both theurlsand in a Import Map defined throughmaps, the rule defined inmapstake precedence.This align the config to be similar to the other build tool plugins.