Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor commits triggers major release of pre-release #1809

Open
trygve-lie opened this issue Feb 19, 2021 · 0 comments
Open

Minor commits triggers major release of pre-release #1809

trygve-lie opened this issue Feb 19, 2021 · 0 comments

Comments

@trygve-lie
Copy link

Current behavior

We have a setup for pre-releases following this workflow. Our only difference is that we have set a next branch to be pre-release.

Our first merge of a PR to the next branch had a breaking change footer. This was detected as a major release and did trigger a new major release (3.0.0-next.1) as expected.

Then we merged a PR marked as feat containing no breaking changes footer into the next branch.

Semantic release detected this as a minor release but did a new major release (4.0.0-next.1):

[11:37:41 AM] [semantic-release] › ℹ  Found git tag v3.0.0-next.1 associated with version 3.0.0-next.1 on branch next
[11:37:41 AM] [semantic-release] › ℹ  Found 2 commits since last release
[11:37:41 AM] [semantic-release] › ℹ  Start step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[11:37:41 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: Merge pull request #90 from gingermusketeer/add-support-for-hapi-servers

Add hapi support for local assets
[11:37:41 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The commit should not trigger a release
[11:37:41 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: feat: Add hapi support for local assets
[11:37:41 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The release type for the commit is minor
[11:37:41 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analysis of 2 commits complete: minor release
[11:37:41 AM] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[11:37:41 AM] [semantic-release] › ℹ  The next release version is 4.0.0-next.1

Ref: https://github.com/eik-lib/common/runs/1934945161?check_suite_focus=true

Expected behavior

We expected that the last PR flagged as a minor to be released as a minor and not a major. In other words; we expected a 3.0.0-next.2 and not a 4.0.0-next.1 release.

Environment

Merlin-Taylor added a commit to Merlin-Taylor/semantic-release that referenced this issue Feb 16, 2022
Document support for GitHub App installation access tokens for users running semantic-release as a GitHub app but outside of GitHub actions.

Fix semantic-release#1809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant