Synchronize date output between calev-core and systemd-analyze #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! The tests are nice, I think you could have also added more lines to this file : https://github.com/eikek/calev/blob/master/modules/core/.jvm/src/test/resources/com/github/eikek/calev/trigger-data.txt -- it is used to create test cases. But obviously, the current way is also fine. To make the format checker happy, could you maybe run |
eikek
approved these changes
May 26, 2024
|
I am glad I could help. Can't wait for the next version of calev. |
|
A new release is just being made and should be available soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch includes a fix for differences between the library and systemd cli mentioned in #553. Test "expression for the daily run on some month with potential next run on next year should start at the beginning of the month next year" verifies problem from the issue, but I added some more tests to be sure.