Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make non-empty basepath work #1263

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Make non-empty basepath work #1263

wants to merge 6 commits into from

Commits on Jan 1, 2022

  1. Add base_path

    @gandy92
    gandy92 committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    a235b7d View commit details
    Browse the repository at this point in the history

  2. Preliminary change check for /app paths, should contain base_path

    @gandy92
    gandy92 committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    5eee5ec View commit details
    Browse the repository at this point in the history

  3. Preliminary hardcode base_path to "/andy"

    @gandy92
    gandy92 committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    a7ec370 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Preliminary hardcode base_path to "/andy"

    @gandy92
    gandy92 committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    8296d37 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2022

  1. Merge branch 'eikek:master' into master

    @gandy92
    gandy92 committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    d05ab92 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Some more trial and error for having a context path 

    - The JoexServer is not affected by this, it is only used internally
  and not exposed, so I would simply skip this

- Sadly, the javascript file has to be fixed as well that creates a
  websocket connection. Can be fixed by making it a template or passing
  the contextPath as argument

- Need to fix the cookie path (I didn't make sure to fix all)

- Another problem is obtaining the base url. Currently, if the config
  is  set to "localhost" we simply clobber the url together from the
  request and here we don't know the base path and simply set the empty
  path. I now fixed this also to be "/andy", but we need to get the
  configured basePath from the config

- Most changes in Elm was fixing the URL to preview images and files
    @eikek
    eikek committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    074bbe1 View commit details
    Browse the repository at this point in the history