Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes configuration #2034

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Add Kubernetes configuration #2034

merged 1 commit into from
Apr 18, 2023

Conversation

waldher
Copy link
Contributor

@waldher waldher commented Apr 9, 2023

For larger deployments, or deployments to clusters, it makes sense that a Kubernetes configuration gets maintained. I added all of the manifests needed to do so in the kubernetes/ directory, and included a Kustomization, which should make it easy to tweak configuration, such as version or database credentials.

@eikek
Copy link
Owner

eikek commented Apr 10, 2023

Hi @waldher - thank you a lot for your work! I have to admit, I'm a bit hesitant to add this. The main concern is that I won't be able to support this. If there arises any issue, I won't be able to help and I won't be able to maintain it further. So … if you like to do that, then it is fine for me 😄 For issues regarding the k8s setup, I would ping you.

Another option is to create a separate repository that can maintain a kubernetes configuration. I know that these configs can grow quite complex. Of course, we can add links into the documentation to these places. wdyt?

@waldher
Copy link
Contributor Author

waldher commented Apr 11, 2023

I'm more than happy to maintain this, as I use it actively.

I don't anticipate a large amount of maintenance, as it's about as much work to maintain as the docker-compose.yaml, and the changes are even the same. Generally, updates to environment variables or changes to the startup commands for restserver or joex necessitate updating here, but not much else is necessary to maintain.

I do think it makes sense to have it in the repository, as it's tightly coupled to the application, and I'd be worried that a separate repository would be neglected.

@eikek
Copy link
Owner

eikek commented Apr 18, 2023

Sorry for the delay! Ok, so we go that way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants