Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CJK and Custom Mapping Documentation #2669

Merged
merged 22 commits into from
Jun 2, 2024

Conversation

tenpai-git
Copy link
Contributor

This resolves #2667 item 3 to add documentation for custom mapping documentation and follow-ups for working with vertical language outputs.

tenpai-git and others added 22 commits February 21, 2024 09:20
…tainer.

Co-Authored-By: eikek <eike.kettner@posteo.de>
…al-support' into add-japanese-vertical-support
@tenpai-git tenpai-git changed the base branch from master to current-docs June 1, 2024 03:38
@eikek
Copy link
Owner

eikek commented Jun 2, 2024

Hi @tenpai-git - since this feature is part of the next release, this documentation update should target the master branch. As you can see, this PR contains many commits from master, that you didn't create :-) The current-docs branch is for documentation of the current release.

@tenpai-git tenpai-git changed the base branch from current-docs to master June 2, 2024 09:01
@tenpai-git
Copy link
Contributor Author

tenpai-git commented Jun 2, 2024

Sorry about that @eikek - I switched to the correct target now! I was targeting current-docs last time because of the last documentation I worked on, but in hindsight, that was to clarify an issue in the current release and like you said this is for next release.

There is an additional change left over in this branch but it should be identical to the previous one I made yesterday. I think we're all good now and I'm looking forward to being apart of the next release!

@eikek eikek added documentation Improvements or additions to documentation skip-changelog and removed skip-changelog labels Jun 2, 2024
@eikek eikek merged commit 67cfcb2 into eikek:master Jun 2, 2024
5 checks passed
@eikek
Copy link
Owner

eikek commented Jun 2, 2024

No reason to be sorry! Thanks for updating. If you think this is now good to go, I'll try to find some time to do the next release.

@tenpai-git
Copy link
Contributor Author

tenpai-git commented Jun 3, 2024

Yup, it should be all good as far as I can tell. Japanese Vertical language option, the custom mappings you did, and improved support for optical character recognition I think should all be listed along with all the dependency updates to resolve other's issues is probably worth a major release.

Hopefully the major release posting helps other CJK-users realize that the support is there for them to build on. Can come back to vertical Korean/Chinese at a later point or another person proficient in those languages can easily use this as a basis to add them.

This has been a pleasure to work on because you've been such a great maintainer @eikek - thank you for everything!!!

@eikek
Copy link
Owner

eikek commented Jun 5, 2024

Thank you @tenpai-git, it was my pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Japanese and CJK Testing & Optimizations
2 participants