fixed ticker cleanup after timeline destroy

eilara · Feb 15, 2012 · 991c7ae · 991c7ae
1 parent 3534b91
commit 991c7ae
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/eg/tween_demo.cpp b/eg/tween_demo.cpp
@@ -72,8 +72,10 @@ void test_Timeline() { // 4 tests
     ok(ticker.last_now == 1, "tick 1 now");
 
     timeline.tick(3);
-    ok(ticker.tick_count == 2, "tick 1 count");
-    ok(ticker.last_now == 3, "tick 1 now");
+    ok(ticker.tick_count == 2, "tick 3 count");
+    ok(ticker.last_now == 3, "tick 3 now");
+
+    timeline.unregister_ticker(&ticker);
 }
 
 // -----------------------------------------------------------------------------

diff --git a/src/Timeline.cpp b/src/Timeline.cpp
@@ -11,11 +11,13 @@ typedef LinearTweenForm<int,1> LinearIntForm;
 typedef LinearTweenForm<float,1> LinearFloatForm;
 
 Timeline::Timeline() : tickers() {
-    for (set<ITicker*>::iterator it = tickers.begin(); it != tickers.end(); it++)
-        (*it)->stop();
 }
 
 Timeline::~Timeline() {
+    for (set<ITicker*>::iterator it = tickers.begin(); it != tickers.end(); it++) {
+        ITicker *ticker = *it;
+        ticker->stop();
+    }
 }
 
 void Timeline::register_ticker(ITicker *ticker) {