-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncomment setting of cancelUrl #2
Uncomment setting of cancelUrl #2
Conversation
I'm writing an Omnipay gateway adapter for a gateway that requires cancelUrl to be set. Was there any particular reason why it was commented out?
it may not have worked for what I was working on - but I'm happy to merge your request - I don't think it will break anything. What gateway are you working on? |
Uncomment setting of cancelUrl
I'm working on a gateway for GoPay, a payment processor widely used in Czech Republic. See https://github.com/sergej-koscejev/omnipay-gopay. |
cool - btw I got that isTransparentRedirect into the common parent class - although I'm not sure it has been pushed up yet (am working on a processor myself at the moment) |
No, it hasn't yet, that's why I had to declare it explicitly as a workaround. Thanks for your work on this multiprocessor! |
cool - I've have to get back & check what is not pushed up - I was working on it about a week ago |
I mean, this was pushed and recently merged but not released yet, so no
|
I'm writing an Omnipay gateway adapter for a gateway that requires cancelUrl to be set. Was there any particular reason why it was commented out?