Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment setting of cancelUrl #2

Merged
merged 1 commit into from
Nov 9, 2014
Merged

Uncomment setting of cancelUrl #2

merged 1 commit into from
Nov 9, 2014

Conversation

sergej-koscejev
Copy link
Contributor

I'm writing an Omnipay gateway adapter for a gateway that requires cancelUrl to be set. Was there any particular reason why it was commented out?

I'm writing an Omnipay gateway adapter for a gateway that requires cancelUrl to be set. Was there any particular reason why it was commented out?
@eileenmcnaughton
Copy link
Owner

it may not have worked for what I was working on - but I'm happy to merge your request - I don't think it will break anything. What gateway are you working on?

eileenmcnaughton added a commit that referenced this pull request Nov 9, 2014
Uncomment setting of cancelUrl
@eileenmcnaughton eileenmcnaughton merged commit 9a0337e into eileenmcnaughton:master Nov 9, 2014
@sergej-koscejev
Copy link
Contributor Author

I'm working on a gateway for GoPay, a payment processor widely used in Czech Republic. See https://github.com/sergej-koscejev/omnipay-gopay.

@sergej-koscejev sergej-koscejev deleted the patch-1 branch November 9, 2014 21:31
@eileenmcnaughton
Copy link
Owner

cool - btw I got that isTransparentRedirect into the common parent class - although I'm not sure it has been pushed up yet (am working on a processor myself at the moment)

@sergej-koscejev
Copy link
Contributor Author

No, it hasn't yet, that's why I had to declare it explicitly as a workaround. Thanks for your work on this multiprocessor!

@eileenmcnaughton
Copy link
Owner

cool - I've have to get back & check what is not pushed up - I was working on it about a week ago

@sergej-koscejev
Copy link
Contributor Author

I mean, this was pushed and recently merged but not released yet, so no
work on your part is necessary.
On Nov 9, 2014 10:41 PM, "Eileen McNaughton" notifications@github.com
wrote:

cool - I've have to get back & check what is not pushed up - I was working
on it about a week ago


Reply to this email directly or view it on GitHub
#2 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants