Format currency before passing to processor

[mattwire]

@eileenmcnaughton Thoughts please? Had an issue recently where sagepay expects a currency formatted to two decimal places but the payment processor was passed one with multiple decimal places because an extension modified the amount before submission (to pro-rata the membership). So we got a value like 10.8333333 which sagepay doesn't like :-)

It's fixed in the extension, but should omnipay be doing any checking/formatting of the amounts?

[eileenmcnaughton]

Here is the Omnipay function - I guess you are hitting the Amount precision below.

Our format money will potentially also mess with the thousand separator so we don't want to use that but perhaps we could query the Omnipay currency for dec places & then round?

check this function in Omnipay
$this->getCurrencyDecimalPlaces()

Function for getAmount pasted below for convenience

    /**
     * Validates and returns the formated amount.
     *
     * @throws InvalidRequestException on any validation failure.
     * @return string The amount formatted to the correct number of decimal places for the selected currency.
     */
    public function getAmount()
    {
        $amount = $this->getParameter('amount');

        if ($amount !== null) {
            // Don't allow integers for currencies that support decimals.
            // This is for legacy reasons - upgrades from v0.9
            if ($this->getCurrencyDecimalPlaces() > 0) {
                if (is_int($amount) || (is_string($amount) && false === strpos((string) $amount, '.'))) {
                    throw new InvalidRequestException(
                        'Please specify amount as a string or float, '
                        . 'with decimal places (e.g. \'10.00\' to represent $10.00).'
                    );
                };
            }

            $amount = $this->toFloat($amount);

            // Check for a negative amount.
            if (!$this->negativeAmountAllowed && $amount < 0) {
                throw new InvalidRequestException('A negative amount is not allowed.');
            }

            // Check for a zero amount.
            if (!$this->zeroAmountAllowed && $amount === 0.0) {
                throw new InvalidRequestException('A zero amount is not allowed.');
            }

            // Check for rounding that may occur if too many significant decimal digits are supplied.
            $decimal_count = strlen(substr(strrchr(sprintf('%.8g', $amount), '.'), 1));
            if ($decimal_count > $this->getCurrencyDecimalPlaces()) {
                throw new InvalidRequestException('Amount precision is too high for currency.');
            }

            return $this->formatCurrency($amount);
        }
    }

[mattwire]

@eileenmcnaughton Something like that sounds good - where would you suggest the actual round takes place? In the getAmount function?

[eileenmcnaughton]

@mattwire - yes I think that makes sense- we are overriding the parent function for that - which seems appropriate

[eileenmcnaughton]

This seems to be a discussion rather than a change being considered so closing