Set optional parameters of http_build_query #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If arg_separator is not set, the default value comes from arg_separator.output which is not always set to the value we need here, which is '&'. On Ubuntu the default is '&'. There is no need to adhere to any system defaults here because we know exactly in which context the URLs we build are used: for a backend request that is executed soon in the same PHP handler. The same parameters are used in the MapQuest provider.
|
@sebalis - Nominatim is a package that we include from https://github.com/geocoder-php/nominatim-provider - can you try submitting your fix to the upstream repo so we can update using composer? |
|
Sure, I’ll see what I can do. |
|
Just noticed that in my extended descripion the Ubuntu setting got mangled – the default there is & and I hope it makes more sense now :-) |
|
A bot there refers me to http://github.com/geocoder-php/Geocoder – is this going to be an endless cycle? :-) |
|
Now at geocoder-php/Geocoder#1131 waiting for workflows to finish. |
|
Do you need/want me to close this PR now, @eileenmcnaughton? |
|
@sebalis yeah maybe close this & open an issue to composer update once they merge it? |
|
Of course, I’ll let you know. Thanks for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If arg_separator is not set, the default value comes from arg_separator.output which is not always set to the value we need here, which is '&'. On Ubuntu the default is '&'. There is no need to adhere to any system defaults here because we know exactly in which context the URLs we build are used: for a backend request that is executed soon in the same PHP handler. The same parameters are used in the MapQuest provider.