Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database upgrade step for 1.9 to update the URL for Open Street Map end point #39

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

agileware-justin
Copy link
Contributor

Add database upgrade step for 1.9 to update the URL for Open Street Map end point

Ping @eileenmcnaughton

Agileware Ref: CIVICRM-2159

@eileenmcnaughton
Copy link
Owner

Thanks @agileware-justin

@eileenmcnaughton eileenmcnaughton merged commit 2586aa7 into eileenmcnaughton:master Aug 8, 2023
@sebalis
Copy link
Contributor

sebalis commented Aug 8, 2023

Thank you, @agileware-justin! See my two (minor) comments.

@eileenmcnaughton
Copy link
Owner

Per ping from @agileware-justin I'm gonna tag 1.10 - the minor comments are improvements - but it's Friday so lets wrap this up this week & we can improve or not later

@sebalis
Copy link
Contributor

sebalis commented Aug 11, 2023

Yes, fine with me, and thanks to @agileware-justin for taking care of the upgrade step. And for giving me the opportunity to finally understand how upgrade steps work :-) This will help me to submit more complete PRs in the future.

@eileenmcnaughton
Copy link
Owner

@sebalis sounds like a win. The gotcha with upgrade steps it remembering to return TRUE - I try to always add type hints cos when someone inevitably copies & pastes them....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants