fix(deps): bump opentelemetry contrib to compatible version #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix breaking change in metric SDK.
|
Does this version include the metrics from otelgrpc? In that case we should remove our own implementation in this library. |
|
v0.37.0 of contrib includes this commit for otelgrpc open-telemetry/opentelemetry-go-contrib@04c5dcb where To prevent double collection of this metric, we should stop collecting it here https://github.com/einride/cloudrunner-go/blob/master/cloudmonitoring/metricmiddleware.go#L24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix breaking change in metric SDK.