Sofia_newfeature #255

OVSofia · 2019-06-25T19:40:40Z

pep8speaks · 2019-06-25T19:40:45Z

Hello @OVSofia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/einsteinpy/tests/test_symbolic/test_vacuum_metrics.py:

Line 16:9: W503 line break before binary operator
Line 22:13: W503 line break before binary operator
Line 24:9: W503 line break before binary operator

Comment last updated at 2019-07-01 05:34:44 UTC

shreyasbapat · 2019-06-26T05:19:25Z

You will have to run:

tox -e reformat

when in einsteinpy folder :)

src/einsteinpy/symbolic/vaccum_metrics.py

src/einsteinpy/symbolic/ricci.py

.gitignore

src/einsteinpy/symbolic/ricci.py

ritzvik · 2019-06-26T07:22:23Z

Hi @OVSofia , thanks for your efforts.
Left some comments.

Also, your branch has diverged too much from the upstream, but don't take pains now. Work on this PR, we would help you fixing the git problem once this PR is final :)

ritzvik · 2019-06-26T07:24:04Z

Fixes #<Put_Issue_Number_Here>

You might want to put the issue numbers this PR is fixing.

OVSofia · 2019-06-26T09:17:42Z

You will have to run:
tox -e reformat
when in einsteinpy folder :)

OH no! :O
I had forgotten

ritzvik · 2019-06-27T03:58:33Z

@OVSofia kindly resolve the comments which you think you have sorted out

src/einsteinpy/symbolic/metric.py

src/einsteinpy/symbolic/ricci.py

src/einsteinpy/symbolic/vaccum_metrics.py

src/einsteinpy/tests/test_symbolic/test_ricci.py

ritzvik · 2019-06-28T02:24:35Z

@OVSofia you can run tox -e reformat or

black ./ and isort -rc ./ while in the src/einsteinpy directory.

ritzvik · 2019-06-28T02:27:52Z

@OVSofia , you can always check whether your tests are working or not on your system.
pytest -vv

or pytest -vv /path/to/file/or/directory for running specific test file or folder.

ritzvik · 2019-06-29T08:44:37Z

Also, @OVSofia could you remove the __setitem__ function from tensor.py as sympy arrays are immutable, calling it would raise TypeError

That was my bad as I didn't see to this earlier.

src/einsteinpy/symbolic/ricci.py

src/einsteinpy/symbolic/tensor.py

src/einsteinpy/symbolic/vaccum_metrics.py

src/einsteinpy/tests/test_symbolic/test_vaccum_metrics.py

src/einsteinpy/tests/test_symbolic/test_vacuum_metrics.py

codecov · 2019-06-30T20:58:48Z

Codecov Report

Merging #255 into master will increase coverage by 0.08%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   94.14%   94.22%   +0.08%     
==========================================
  Files          28       29       +1     
  Lines        1024     1057      +33     
==========================================
+ Hits          964      996      +32     
- Misses         60       61       +1

Impacted Files	Coverage Δ
src/einsteinpy/symbolic/vacuum_metrics.py	`100% <100%> (ø)`
src/einsteinpy/symbolic/tensor.py	`100% <100%> (ø)`	⬆️
src/einsteinpy/symbolic/ricci.py	`95.65% <95.23%> (-4.35%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e869ea7...1ac1139. Read the comment docs.

codecov · 2019-06-30T20:58:49Z

Codecov Report

Merging #255 into master will increase coverage by 0.08%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   94.14%   94.22%   +0.08%     
==========================================
  Files          28       29       +1     
  Lines        1024     1057      +33     
==========================================
+ Hits          964      996      +32     
- Misses         60       61       +1

Impacted Files	Coverage Δ
src/einsteinpy/symbolic/vacuum_metrics.py	`100% <100%> (ø)`
src/einsteinpy/symbolic/tensor.py	`100% <100%> (ø)`	⬆️
src/einsteinpy/symbolic/ricci.py	`95.65% <95.23%> (-4.35%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e869ea7...1ac1139. Read the comment docs.

codecov · 2019-06-30T20:58:49Z

Codecov Report

Merging #255 into master will increase coverage by 0.09%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   93.64%   93.74%   +0.09%     
==========================================
  Files          30       31       +1     
  Lines        1102     1135      +33     
==========================================
+ Hits         1032     1064      +32     
- Misses         70       71       +1

Impacted Files	Coverage Δ
src/einsteinpy/symbolic/vacuum_metrics.py	`100% <100%> (ø)`
src/einsteinpy/symbolic/tensor.py	`100% <100%> (ø)`	⬆️
src/einsteinpy/symbolic/ricci.py	`95.65% <95.23%> (-4.35%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ccce0c...f76099b. Read the comment docs.

codecov · 2019-06-30T20:58:49Z

Codecov Report

Merging #255 into master will increase coverage by 0.08%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   94.14%   94.22%   +0.08%     
==========================================
  Files          28       29       +1     
  Lines        1024     1057      +33     
==========================================
+ Hits          964      996      +32     
- Misses         60       61       +1

Impacted Files	Coverage Δ
src/einsteinpy/symbolic/vacuum_metrics.py	`100% <100%> (ø)`
src/einsteinpy/symbolic/tensor.py	`100% <100%> (ø)`	⬆️
src/einsteinpy/symbolic/ricci.py	`95.65% <95.23%> (-4.35%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e869ea7...1ac1139. Read the comment docs.

ritzvik · 2019-07-01T00:15:52Z

@OVSofia, see all the tests have passed now.
You have to now rebase your branch.

git pull --rebase upstream master
git push origin sof_newfeature -f

This is would be good for merging then.

…ests

… indentation

…Fix docstrings. Remove kerr function from vacumm_metrics and last updates of test scripts. Moreover, move under the init of TensorClass getting and setting methods

shreyasbapat · 2019-07-01T06:19:36Z

Don't add labels!

shreyasbapat · 2019-07-01T06:21:03Z

@OVSofia I have edited your Pull request description! Please have a look and see how I linked the respective issues!
Please make sure that from the next time, you also do the same!

shreyasbapat · 2019-07-01T06:22:08Z

I was waiting for this pull request to complete. Otherwise we would not have had any new features from SOCIS student in the release!
Now after @Varunvaruns9 makes his Pull request, Feature Freeze will begin!

shreyasbapat · 2019-07-01T06:22:36Z

I am merging this!

ritzvik · 2019-07-01T06:39:51Z

Both @OVSofia and I forgot to add the docs for Ricci Tensor and Vacuum metrics.
@shreyasbapat Kindly do this with any of your PRs

OVSofia · 2019-07-01T06:40:12Z

I was waiting for this pull request to complete. Otherwise we would not have had any new features from SOCIS student in the release!
Now after @Varunvaruns9 makes his Pull request, Feature Freeze will begin!

Ohh okey! And how long will it last? Can I make push when the Feature Freeze is underway?

ritzvik · 2019-07-01T06:46:39Z

I was waiting for this pull request to complete. Otherwise we would not have had any new features from SOCIS student in the release!
Now after @Varunvaruns9 makes his Pull request, Feature Freeze will begin!

Ohh okey! And how long will it last? Can I make push when the Feature Freeze is underway?

You can make PRs as you wish. It would just not be merged!
BTW see #267

shreyasbapat · 2019-07-01T08:27:24Z

They will be merged but in master! Not in 0.2.x branch!

ritzvik requested changes Jun 26, 2019

View reviewed changes

OVSofia force-pushed the sof_newfeature branch from cc66839 to 898280d Compare June 27, 2019 18:25

ritzvik requested changes Jun 28, 2019

View reviewed changes

ritzvik requested changes Jun 29, 2019

View reviewed changes

ritzvik added the 1 - In Progress label Jun 30, 2019

ritzvik reviewed Jun 30, 2019

View reviewed changes

src/einsteinpy/tests/test_symbolic/test_vacuum_metrics.py Show resolved Hide resolved

OVSofia added 7 commits July 1, 2019 07:33

Support indexing for Tensor object in symbolic module einsteinpy#245

1dc33b8

Create and implement vaccum_metrics. Implement Ricci Tensor. Modify t…

38b2faf

…ests

Modify Ricci Tensor from christoffel method and add from riemann. Fix…

a27109b

… indentation

Fix from_christoffel and from_metric methods from RicciTensor Class. …

e22e554

…Fix docstrings. Remove kerr function from vacumm_metrics and last updates of test scripts. Moreover, move under the init of TensorClass getting and setting methods

Fix metric, ricci, vaccum_metrics and test_ricci of symbolics

959c62f

Fix test, vacuum_metrics and tensor

7faf180

Fix test_ vacuum_metrics and ricci

f76099b

OVSofia force-pushed the sof_newfeature branch from 1ac1139 to f76099b Compare July 1, 2019 05:34

ritzvik added 2 - Ready and removed 1 - In Progress labels Jul 1, 2019

shreyasbapat merged commit 54f25e0 into einsteinpy:master Jul 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sofia_newfeature #255

Sofia_newfeature #255

OVSofia commented Jun 25, 2019 •

edited by shreyasbapat

pep8speaks commented Jun 25, 2019 •

edited

shreyasbapat commented Jun 26, 2019

ritzvik commented Jun 26, 2019

ritzvik commented Jun 26, 2019

OVSofia commented Jun 26, 2019

ritzvik commented Jun 27, 2019

ritzvik commented Jun 28, 2019

ritzvik commented Jun 28, 2019

ritzvik commented Jun 29, 2019

codecov bot commented Jun 30, 2019

codecov bot commented Jun 30, 2019

codecov bot commented Jun 30, 2019 •

edited

codecov bot commented Jun 30, 2019

ritzvik commented Jul 1, 2019

shreyasbapat commented Jul 1, 2019

shreyasbapat commented Jul 1, 2019

shreyasbapat commented Jul 1, 2019 •

edited

shreyasbapat commented Jul 1, 2019

ritzvik commented Jul 1, 2019

OVSofia commented Jul 1, 2019

ritzvik commented Jul 1, 2019

shreyasbapat commented Jul 1, 2019

Sofia_newfeature #255

Sofia_newfeature #255

Conversation

OVSofia commented Jun 25, 2019 • edited by shreyasbapat

pep8speaks commented Jun 25, 2019 • edited

Comment last updated at 2019-07-01 05:34:44 UTC

shreyasbapat commented Jun 26, 2019

ritzvik commented Jun 26, 2019

ritzvik commented Jun 26, 2019

OVSofia commented Jun 26, 2019

ritzvik commented Jun 27, 2019

ritzvik commented Jun 28, 2019

ritzvik commented Jun 28, 2019

ritzvik commented Jun 29, 2019

codecov bot commented Jun 30, 2019

Codecov Report

codecov bot commented Jun 30, 2019

Codecov Report

codecov bot commented Jun 30, 2019 • edited

Codecov Report

codecov bot commented Jun 30, 2019

Codecov Report

ritzvik commented Jul 1, 2019

shreyasbapat commented Jul 1, 2019

shreyasbapat commented Jul 1, 2019

shreyasbapat commented Jul 1, 2019 • edited

shreyasbapat commented Jul 1, 2019

ritzvik commented Jul 1, 2019

OVSofia commented Jul 1, 2019

ritzvik commented Jul 1, 2019

shreyasbapat commented Jul 1, 2019

OVSofia commented Jun 25, 2019 •

edited by shreyasbapat

pep8speaks commented Jun 25, 2019 •

edited

codecov bot commented Jun 30, 2019 •

edited

shreyasbapat commented Jul 1, 2019 •

edited