Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues #21

Closed
terencechow opened this issue Jan 18, 2016 · 2 comments
Closed

Performance issues #21

terencechow opened this issue Jan 18, 2016 · 2 comments

Comments

@terencechow
Copy link

I have 12 objects in my Masonry container. Upon changing one of the objects, the entire masonry component must update.

However I'm seeing quite a significant jank as a result. When I use an ordinary container instead of a Masonry container the jank does not occur.

Any reasons why? In my 12 objects I return false in shouldComponentUpdate for 11 of them so I know only 1 rerenders, and the masonry rerenders, but I don't understand the jank that Masony is causing.

Any suggestions what may be the cause?

@afram
Copy link
Collaborator

afram commented Jan 18, 2016

The jank may be due to all the computation masonry is doing. Do you have a small test case for debugging purposes?

@afram
Copy link
Collaborator

afram commented May 2, 2016

@Chowza I am going to close this due to inactivity. Please reopen if this is still an issue for you. :-)

@afram afram closed this as completed May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants