typings.d.ts using export as namespace syntax as recommended for exte… #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, will merge it in now and fix the tests before publishing. Will let you know when it is published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rnal modules
https://www.typescriptlang.org/docs/handbook/modules.html
It is recommended for "external modules" e.g. npm installable modules to use this syntax for declaration files.
Also, the current typings file prevents any typescript project from using this repo:
error TS2666: Exports and export assignments are not permitted in module augmentations.And modules that provide a "typings" field in package.json cannot blacklist an incorrect typings file.