Add a bunch of tests for Drupal advisories being attached (#204)

* Add a bunch of tests for Drupal advisories being attached * Code style * phpstan fix * Add a test about Drupal 8 non-sec as well
eiriksm · Apr 13, 2021 · 6a3e1ea · 6a3e1ea
1 parent 7f6815c
commit 6a3e1ea
Showing 1 changed file with 162 additions and 0 deletions.
diff --git a/test/integration/DrupalRuntimeSecUpdateTest.php b/test/integration/DrupalRuntimeSecUpdateTest.php
@@ -0,0 +1,162 @@
+<?php
+
+namespace eiriksm\CosyComposerTest\integration;
+
+use eiriksm\ArrayOutput\ArrayOutput;
+use Http\Adapter\Guzzle6\Client;
+use Violinist\Slug\Slug;
+
+class DrupalRuntimeSecUpdateTest extends ComposerUpdateIntegrationBase
+{
+
+    /**
+     * @dataProvider getDrupalUpdatesAndSec
+     */
+    public function testDrupalSecUpdates($version, $package, $sec)
+    {
+        $composer_contents = json_encode([
+            'require' => [
+                $package => $version,
+            ],
+        ]);
+        $dir = $this->dir;
+        $composer_file = "$dir/composer.json";
+        file_put_contents($composer_file, $composer_contents);
+        $this->getMockOutputWithUpdates($package, $version);
+        $this->placeComposerLock($version, $package);
+        $mock_executer = $this->getMockExecuterWithReturnCallback(
+            function ($cmd) use ($package, $version) {
+                $return = 0;
+                $new_version = $this->incrementVersion($version);
+                $expected_command = $this->createExpectedCommandForRequiredPackage($package, $new_version);
+                if ($cmd == $expected_command) {
+                    $this->placeUpdatedLockFile($version, $package);
+                }
+                $this->handleExecutorReturnCallback($cmd, $return);
+                return $return;
+            }
+        );
+        $this->cosy->setExecuter($mock_executer);
+        $this->mockProvider->method('createPullRequest')
+            ->willReturnCallback(function (Slug $slug, array $params) {
+                $this->prParams = $params;
+                return [
+                    'html_url' => $this->fakePrUrl,
+                ];
+            });
+        $this->cosy->setHttpClient(new Client());
+        $this->runtestExpectedOutput();
+        $output = $this->cosy->getOutput();
+        self::assertEquals($sec, strpos($this->prParams["title"], '[SECURITY]') === 0);
+    }
+
+    protected function createExpectedCommandForRequiredPackage($package, $new_version)
+    {
+        return "composer require -n --no-ansi $package:$new_version --update-with-dependencies ";
+    }
+
+    public function placeUpdatedLockFile($version, $package)
+    {
+        $new_version = $this->incrementVersion($version);
+        $this->placeComposerLock($new_version, $package);
+    }
+
+    public function placeComposerLock($version, $package)
+    {
+        $lock_contents = json_encode([
+            'packages-dev' => [],
+            'packages' => [
+                [
+                    'name' => $package,
+                    'version' => $version,
+                ],
+                [
+                    'name' => 'drupal/core',
+                    'version' => $version,
+                ],
+            ],
+        ]);
+        $dir = $this->dir;
+        $lock_file = "$dir/composer.lock";
+        file_put_contents($lock_file, $lock_contents);
+    }
+
+    protected function incrementVersion($version)
+    {
+        $version_array = explode('.', $version);
+        $key = 2;
+        if (empty($version_array[$key])) {
+            $key = 1;
+        }
+        $version_array[$key] = (int) $version_array[$key] + 1;
+        $new_version = implode('.', $version_array);
+        return $new_version;
+    }
+
+    protected function getMockOutputWithUpdates($package, $version)
+    {
+        $mock_output = $this->createMock(ArrayOutput::class);
+        $new_version = $this->incrementVersion($version);
+        $mock_output->method('fetch')
+            ->willReturn([
+                [
+                    $this->createUpdateJsonFromData($package, $version, $new_version),
+                ]
+            ]);
+        if ($this->cosy) {
+            $this->cosy->setOutput($mock_output);
+        }
+        return $mock_output;
+    }
+
+    protected function placeInitialComposerLock()
+    {
+        // Empty on purpose, since we place those files more dynamically.
+    }
+
+    public function getDrupalUpdatesAndSec()
+    {
+        return [
+            [
+                '9.99.6',
+                'drupal/core-recommended',
+                false,
+            ],
+            [
+                '9.1.2',
+                'drupal/core-recommended',
+                true,
+            ],
+            [
+                '8.0.6',
+                'drupal/core',
+                true,
+            ],
+            [
+                '8.10.6',
+                'drupal/core',
+                false,
+            ],
+            [
+                '7.212',
+                'drupal/core',
+                false
+            ],
+            [
+                '7.0',
+                'drupal/core',
+                true
+            ],
+            [
+                '10.9.8',
+                'drupal/core',
+                false,
+            ],
+            [
+                '70.55.86',
+                'drupal/core',
+                false,
+            ],
+        ];
+    }
+}