Add more on the provider factory test

eiriksm · Aug 29, 2020 · a2dc644 · a2dc644
1 parent 2b895b7
commit a2dc644
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 12 deletions.
diff --git a/src/ProcessWrapper.php b/src/ProcessWrapper.php
@@ -13,14 +13,6 @@ class ProcessWrapper extends Process
      */
     protected $executor;
 
-    /**
-     * @return CommandExecuter
-     */
-    public function getExecutor()
-    {
-        return $this->executor;
-    }
-
     /**
      * @param CommandExecuter $executor
      */

diff --git a/test/unit/ProviderFactoryTest.php b/test/unit/ProviderFactoryTest.php
@@ -3,17 +3,51 @@
 namespace eiriksm\CosyComposerTest\unit;
 
 use eiriksm\CosyComposer\ProviderFactory;
+use eiriksm\CosyComposer\Providers\Bitbucket;
 use eiriksm\CosyComposer\Providers\Github;
+use eiriksm\CosyComposer\Providers\Gitlab;
+use eiriksm\CosyComposer\Providers\SelfHostedGitlab;
 use PHPUnit\Framework\TestCase;
 use Violinist\Slug\Slug;
 
 class ProviderFactoryTest extends TestCase
 {
-    public function testCreateFromHost()
+    /**
+     * @dataProvider getHostAndClass
+     */
+    public function testCreateFromHost($url, $class)
     {
+        if ($url === 'https://bitbucket.org/eiriksm/cosy-composer' && version_compare(phpversion(), "7.1.0", "<=")) {
+            $this->assertTrue(true, 'Skipping bitbucket test for version ' . phpversion());
+            return;
+        }
         $pf = new ProviderFactory();
-        $slug = Slug::createFromUrl('https://github.com/eiriksm/cosy-composer');
-        $provider = $pf->createFromHost($slug, []);
-        $this->assertEquals(get_class($provider), Github::class);
+        $slug = Slug::createFromUrl($url);
+        $url_array = parse_url($url);
+        $url_array['port'] = 443;
+        $provider = $pf->createFromHost($slug, $url_array);
+        $this->assertEquals(get_class($provider), $class);
+    }
+
+    public function getHostAndClass()
+    {
+        return [
+            [
+                'https://github.com/eiriksm/cosy-composer',
+                Github::class
+            ],
+            [
+                'https://gitlab.com/eiriksm/cosy-composer',
+                Gitlab::class
+            ],
+            [
+                'https://bitbucket.org/eiriksm/cosy-composer',
+                Bitbucket::class
+            ],
+            [
+                'https://example.com/eiriksm/cosy-composer',
+                SelfHostedGitlab::class
+            ],
+        ];
     }
 }