Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add few new ad types #10

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 6, 2021

No description provided.

ghost pushed a commit that referenced this pull request Dec 6, 2021
@ghost ghost force-pushed the feature/add-few-new-ad-types branch from 4e31f81 to d28606f Compare December 6, 2021 12:08
ghost pushed a commit that referenced this pull request Dec 6, 2021
@ghost ghost force-pushed the feature/add-few-new-ad-types branch from d28606f to fe03742 Compare December 6, 2021 12:15
@ghost ghost force-pushed the feature/add-few-new-ad-types branch from fe03742 to 2e91435 Compare December 6, 2021 12:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 65

  • 0 of 112 (0.0%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-6.6%) to 48.914%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/AdTypes/CaravanXml.php 0 1 0.0%
src/AdType.php 0 3 0.0%
src/AdTypes/BoatXml.php 0 3 0.0%
src/AdTypes/MotorMiscXml.php 0 11 0.0%
src/Traits/PriceTrait.php 0 17 0.0%
src/AdTypes/BoatMotorXml.php 0 25 0.0%
src/AdTypes/MobileHomeXml.php 0 52 0.0%
Files with Coverage Reduction New Missed Lines %
src/AdTypes/BoatXml.php 2 0%
Totals Coverage Status
Change from base Build 56: -6.6%
Covered Lines: 428
Relevant Lines: 875

💛 - Coveralls

@ghost ghost requested a review from eiriksm December 6, 2021 12:24
Copy link
Owner

@eiriksm eiriksm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great lets do it

@eiriksm eiriksm merged commit 49b1a3f into master Dec 6, 2021
@eiriksm eiriksm deleted the feature/add-few-new-ad-types branch December 6, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants