Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set agri category segment type handling #12

Merged
merged 3 commits into from Aug 3, 2023
Merged

Set agri category segment type handling #12

merged 3 commits into from Aug 3, 2023

Conversation

ivanruzak
Copy link
Collaborator

No description provided.

@ivanruzak ivanruzak marked this pull request as ready for review August 3, 2023 07:33
@eiriksm
Copy link
Owner

eiriksm commented Aug 3, 2023 •
edited

Hm I was sure there were tests for this library, but I see they are on travis 😡

While I fix that, I can see there are some coding standard errors:

FILE: /home/eirik/github/finn-transfer-sdk/src/AdTypes/AgriXml.php
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
 60 | ERROR | [x] The closing brace for the class must go on the next line after the body
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------


FILE: /home/eirik/github/finn-transfer-sdk/src/Traits/SegmentPropertyTrait.php
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
 50 | ERROR | [x] The closing brace for the trait must go on the next line after the body
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------

@eiriksm
Copy link
Owner

eiriksm commented Aug 3, 2023

If you can merge in the latest from master, there should be tests running now

@ivanruzak
Copy link
Collaborator Author

Here they are 🙂

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5748050240

  • 7 of 11 (63.64%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 70.48%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Traits/SegmentPropertyTrait.php 5 9 55.56%
Totals Coverage Status
Change from base Build 5748036103: -0.5%
Covered Lines: 499
Relevant Lines: 708
💛 - Coveralls

@eiriksm eiriksm merged commit 69bc603 into eiriksm:master Aug 3, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiriksm eiriksm eiriksm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanruzak @eiriksm @coveralls