fix stix ioc fetch failure scenario

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep · Jul 2, 2024 · b7a1a19 · b7a1a19
1 parent d88b9fd
commit b7a1a19
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFetchService.java b/src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFetchService.java
@@ -111,6 +111,7 @@ public void downloadAndIndexIOCs(SATIFSourceConfig saTifSourceConfig, ActionList
         } catch (Exception e) {
             log.error("Failed to download IOCs.", e);
             listener.onFailure(e);
+            return;
         }
 
         // TODO consider passing listener into the flush IOC function

diff --git a/.../opensearch/securityanalytics/threatIntel/service/SATIFSourceConfigManagementService.java b/.../opensearch/securityanalytics/threatIntel/service/SATIFSourceConfigManagementService.java
@@ -167,7 +167,7 @@ public void createIocAndTIFSourceConfig(
                                                                 listener.onFailure(e);
                                                             }, ex -> {
                                                                 log.error("Failed to delete threat intel source config [{}]", indexSaTifSourceConfigResponse.getId());
-                                                                listener.onFailure(ex);
+                                                                listener.onFailure(e);
                                                             }
                                                     ));
                                                 })