Add initial support for simplified hover type information #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The type message looks like this now: |
|
@wmdietl Hi Werner, I have complete the feature of simpler type hover information. Please review it. I am not sure why I can request review or assign you directly. |
wmdietl
reviewed
Nov 27, 2023
wmdietl
requested changes
Nov 27, 2023
src/main/java/org/checkerframework/languageserver/CFTextDocumentService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkerframework/languageserver/CheckerTypeKind.java
Outdated
Show resolved
Hide resolved
| public class CheckerTypeKind { | ||
| private String checkername; | ||
|
|
||
| private Map<String, String> TypeKind; |
There was a problem hiding this comment.
What is this mapping from/to?
Field names should start lower case.
There was a problem hiding this comment.
The map stores type information in the key of the map and type kind information e.g. used/declared in the value of the map.
src/main/java/org/checkerframework/languageserver/CheckerTypeKind.java
Outdated
Show resolved
Hide resolved
| for (CheckerTypeKind checkerTypeKind : checkerTypeKinds) { | ||
| if (checkerTypeKind.getCheckername().equals(checker)) { | ||
| foundChecker = true; | ||
| if (!checkerTypeKind.getTypeKind().containsKey(type)) { |
There was a problem hiding this comment.
These methods have a very deep nesting level. Can you try to split off smaller helper methods? Or at least add some comments to make the flow understandable?
There was a problem hiding this comment.
already refactored and added comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it looks like this, still working on more features.
I will rebase this PR to #238