Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.7.8 having the same External ping duration bug as #2 #5

Closed
otzy007 opened this issue Jan 19, 2016 · 6 comments
Closed

Release 1.7.8 having the same External ping duration bug as #2 #5

otzy007 opened this issue Jan 19, 2016 · 6 comments

Comments

@otzy007
Copy link

otzy007 commented Jan 19, 2016

Hi,

It looks like 1.7.8 release on rubygems has this bug with Ping::External where the time is incorrectly computed

Open3.popen3(*pcmd) do |stdin, stdout, stderr, thread|
          stdin.close
          @end_time = Time.now

It's the same bug found on #2 but fixed on master.
Wasn't this bug fixed on 1.7.8?
Also the changelog is stopped at 1.7.7 https://github.com/chernesk/net-ping/blob/master/CHANGES

@chernesk
Copy link
Collaborator

Thank you for the bug report. I'll check this out and get a fix out as soon as I can.

@otzy007
Copy link
Author

otzy007 commented Feb 17, 2016

ok. Thank you 😀

@chernesk
Copy link
Collaborator

chernesk commented Aug 5, 2016

I believe this was fixed with v2.0.0. Please re-open if this is still an issue.

@chernesk chernesk closed this as completed Aug 5, 2016
@otzy007
Copy link
Author

otzy007 commented Aug 5, 2016

@chernesk Thank you. I'll check and get back to you.

@otzy007
Copy link
Author

otzy007 commented Sep 6, 2016

I can confirm that on v2 the response time is right. Thank you 😀

@chernesk
Copy link
Collaborator

chernesk commented Sep 6, 2016

Thanks @otzy007..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants