Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon cached too long in bookmark #23

Closed
adambom opened this issue Nov 4, 2013 · 3 comments
Closed

Favicon cached too long in bookmark #23

adambom opened this issue Nov 4, 2013 · 3 comments
Assignees
@ejci
Labels
enhancement
Milestone
0.3.3

Comments

@adambom
Copy link
Contributor

adambom commented Nov 4, 2013

I have my site in my bookmarks toolbar in chrome. I've noticed that if I close the window while the favicon is displaying a non-zero number, it remains that way in the bookmarks toolbar. Is there any way to counteract this that you know of?
@ejci
Copy link
Owner

ejci commented Nov 5, 2013

I will try to use onunload / onbeforeunload event to reset favicon before page close...

@ghost ghost assigned ejci Nov 5, 2013
@adambom
Copy link
Contributor Author

adambom commented Nov 5, 2013

Do you think favico.js is the best place for that? Should it be handled by the user instead? Couldn't this cause issues where we end up overwriting an existing onbeforeunload handler.

@ejci
Copy link
Owner

ejci commented Nov 6, 2013

Maybe you are right...
But I will try and if it works I will include this "hack" on example page.

@ejci ejci closed this as completed in 5054f53 Nov 10, 2013
lorenzhs added a commit to lorenzhs/glowing-bear that referenced this issue Feb 10, 2014
@lorenzhs
Reset favico on unloading. Should resolve bookmark favicon issue.
6b31a3e 
See ejci/favico.js#23 for detail
@lorenzhs lorenzhs mentioned this issue Feb 10, 2014
Merged
kevinji added a commit to kevinji/Reddit-Enhancement-Suite that referenced this issue Jul 11, 2014
@kevinji
betteReddit: Reset favicon when unloading page
ab75db4 
Prevents notification icon from being cached in bookmarks. Per
ejci/favico.js#23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ejci ejci

Labels
enhancement
Projects
None yet
Milestone
0.3.3
Development

No branches or pull requests
2 participants
@adambom @ejci