Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for future deprecation of datetime.datetime.utcnow() #1079

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix for future deprecation of datetime.datetime.utcnow() #1079

merged 2 commits into from
Dec 7, 2023

Conversation

ejeschke
Copy link
Owner

@ejeschke ejeschke commented Dec 7, 2023

utcnow() will be deprecated in Python 3.12

@ejeschke ejeschke added the maintenance Work done to keep code maintained label Dec 7, 2023
@ejeschke ejeschke added this to the 5.0 milestone Dec 7, 2023
@ejeschke ejeschke self-assigned this Dec 7, 2023
@ejeschke ejeschke requested a review from pllim December 7, 2023 00:32
@github-actions github-actions bot added reference viewer plugin and removed maintenance Work done to keep code maintained labels Dec 7, 2023
@ejeschke
Copy link
Owner Author

ejeschke commented Dec 7, 2023

Another very short one @pllim. Any objections to merge?

@ejeschke
Copy link
Owner Author

ejeschke commented Dec 7, 2023

Yay! RTD build is going again!

pllim
pllim approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM FFTM thx :)

@ejeschke
Copy link
Owner Author

ejeschke commented Dec 7, 2023

TY@pllim

@ejeschke ejeschke merged commit a95f360 into ejeschke:main Dec 7, 2023
10 checks passed
@ejeschke ejeschke deleted the fix-datetime-utc branch December 7, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

Assignees

@ejeschke ejeschke

Labels
plugin reference viewer
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ejeschke @pllim