Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use svg icons #1083

Merged
merged 9 commits into from
Jan 3, 2024
Merged

Use svg icons #1083

merged 9 commits into from
Jan 3, 2024

Conversation

ejeschke
Copy link
Owner

@ejeschke ejeschke commented Jan 1, 2024

  • Change the PNG (bitmap) icons to SVG (vector, scalable) icons
  • Improve cursor handling and make scalable cursors
  • Replace some icons with (hopefully) more intuitive ones

@ejeschke ejeschke added this to the 5.0 milestone Jan 1, 2024
@ejeschke ejeschke self-assigned this Jan 1, 2024
@github-actions github-actions bot added reference viewer plugin maintenance Work done to keep code maintained widget labels Jan 1, 2024
@ejeschke
Copy link
Owner Author

ejeschke commented Jan 2, 2024

@pllim, when you get a chance can you simply review the look of the new icons and give me any feedback on them? I think they should be a bit more intuitive than the old ones.

Copy link
Collaborator

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not UX/UI designer so I don't know how legit my review is. Overall I think they look good. Thanks!

If you have "dark mode" in your roadmap, you might want to see if they can be easily inverted for dark mode. Otherwise, you can ignore this paragraph.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this one for? Looks almost transparent.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one is a cursor, activated in 'draw' mode, which is not used by most users of the reference viewer (activated by space, then 'b'), since they can simply right-drag to draw or the plugin will offer a toggle button for move/draw/edit, etc.

But I am thinking of using it for indicating drawing in the future, and would like to have it in the cursors. I've tweaked it a bit to make it more visible in the normal range of contrast.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this one in the default layout. The A looks a bit off-center.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the toolbar, right after reset rotation icon. Probably a lot of users use the button in the Synopsis (Info) plugin for auto cuts usually--but it is there in the toolbar.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one reminds me of Instagram but I guess it is okay if there is no better icon to use.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me see if I can find something better.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

center_image

It would show up much smaller, of course.

@ejeschke
Copy link
Owner Author

ejeschke commented Jan 2, 2024

If you have "dark mode" in your roadmap, you might want to see if they can be easily inverted for dark mode. Otherwise, you can ignore this paragraph.

Hmm, sounds like support for "themes" or "skins". Will consider for the future, but probably pretty low priority.

@ejeschke ejeschke merged commit 4e69946 into ejeschke:main Jan 3, 2024
10 checks passed
@ejeschke
Copy link
Owner Author

ejeschke commented Jan 3, 2024

Thanks, @pllim! We can further tweak the icons as needed down the road. I will update the documentation in a separate commit, since there are some other doc changes I want to do. Several screenshots showing the toolbar need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants