[vscode] cleanup command names #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
reviewed
May 9, 2024
There was a problem hiding this comment.
Ok to me, I'm not sure if some information on what the commands do is lost tho, hard for me to judge. Couple of points:
- coq-lsp.document: Maybe we should specify what format the document is, anyways this is just a debug call (unless we connect this call to a JSON visualizer, that could be cool actually! Maybe we could just put the output of the request in an ephemeral document-version.json file that is then opened?
- sentenceNext/Back: note that these commands are just an approximation, so they can often fail or be imprecise.
- trim: no idea if that sound too technical
|
The main reason for keeping these names short is that they show up on |
|
For |
|
I'll rebase |
Alizter
force-pushed
the
ps/rr/cleanup_command_names
branch
5 times, most recently
from
d9a67a2
to
527c992
Compare
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
ps/rr/cleanup_command_names
branch
from
527c992
to
84a7611
Compare
|
@ejgallego I've rebased and tweaked the wording. |
ejgallego
added
kind: enhancement
|
Thanks Ali, I will tweak the working to say "serialize and display in a new window", as the command now opens a new windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.