[fleche] [controller] First steps towards resumption #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
queue_preempt
branch
9 times, most recently
from
19b40c0
to
d9a7a01
Compare
As of today, checking a document can only be preempted by another `didChanges` request. This is inconvenient when working in large documents, as we would like goals or hover to be able to interrupt it. We add support in the controller for preempting checking by requests. The logic is that we keep a pointer for checking under progress, which is only set to `None` when the fleche notifies the checking has been completed. The queue manager will preempt checking for all requests, and the queue is empty, resume checking if pending. As of this PR, resuming checking will re-check the document in full (with memoization of course); this is to be improved likely in a different PR, maybe after parsing memo? Note that this interacts with other desired features such as lazy / viewrange checking, parsing memoization, and other features in non-trivial ways. Fixes #70
ejgallego
force-pushed
the
queue_preempt
branch
from
d9a7a01
to
05db81e
Compare
ejgallego
changed the title
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Nov 20, 2022
CHANGES: ----------------------- - Location-aware cache for incremental Coq interpretation (@ejgallego) - Smart, structure-aware error recovery (@ejgallego) - Configure flags reading _CoqProject file (@artagnon, ejgallego/coq-lsp#3) - Interruption support (@ejgallego , @Alizter, ejgallego/coq-lsp#27, ejgallego/coq-lsp#32, ejgallego/coq-lsp#34) - Markdown support (@ejgallego, ejgallego/coq-lsp#62) - Goal display (@ejgallego @corwin-of-amber, ejgallego/coq-lsp#69) - User-side configuration (@ejgallego, ejgallego/coq-lsp#67) - Allow to configure before/after goal display (@ejgallego, ejgallego/coq-lsp#78) - Allow requests to interrupt checking (@ejgallego, ejgallego/coq-lsp#76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today, checking a document can only be preempted by another
didChangesrequest. This is inconvenient when working in large documents, as we would like goals or hover to be able to interrupt it.We add support in the controller for preempting checking by requests. The logic is that we keep a pointer for checking under progress, which is only set to
Nonewhen the fleche notifies the checking has been completed. The queue manager will preempt checking for all requests, and the queue is empty, resume checking if pending.As of this PR, resuming checking will re-check the document in full (with memoization of course); this is to be improved likely in a different PR, maybe after parsing memo?
Note that this interacts with other desired features such as lazy / viewrange checking, parsing memoization, and other features in non-trivial ways.
Fixes #70