Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for -indices-matter #222

Closed
cpitclaudel opened this issue Aug 5, 2020 · 1 comment · Fixed by ocaml/opam-repository#17070
Closed

Support for -indices-matter #222

cpitclaudel opened this issue Aug 5, 2020 · 1 comment · Fixed by ocaml/opam-repository#17070

Comments

@cpitclaudel
Copy link
Collaborator

Coqc and coqtop support -indices-matter; it's needed by HoTT. Is there a way to use it with SerAPI? If not, it would be nice to add it.

@ejgallego
Copy link
Owner

Indeed the initialization is quite messy, hopefully I can push a refactor to Coq itself so this kind of code is better shared.

@ejgallego ejgallego self-assigned this Aug 26, 2020
@ejgallego ejgallego modified the milestones: 0.12.0, 0.11.1 Aug 26, 2020
ejgallego added a commit that referenced this issue Aug 26, 2020
[sertop] Fix #222 "Support --indices-matter"
ejgallego added a commit to ejgallego/opam-repository that referenced this issue Aug 26, 2020
CHANGES:

* [general] Require dune >= 2.0 (@ejgallego, ??)
 * [serapi]  New query `Comments` to return all comments in a document
             (@ejgallego, ejgallego/coq-serapi#20? , (partially) fixes ejgallego/coq-serapi#191 , ejgallego/coq-serapi#200 )
 * [general] Coq's error recovery is now disabled by default
             (@ejgallego , fixes ejgallego/coq-serapi#201)
 * [general] New option `--error-recovery` to enable error recovery
             (@ejgallego , ejgallego/coq-serapi#203)
 * [general] Bump sexplib dependency to v0.13 (@ejgallego , ejgallego/coq-serapi#204)
             Fixes incorrect change in ejgallego/coq-serapi#194.
 * [sertop]  Set default value of allow-sprop to be true in agreement with upstream coq v8.11
             and added option '--disallow-sprop' to optionally switch it off
			 (--disallow-sprop forbids using the proof irrelevant SProp sort)
             (ejgallego/coq-serapi#199, @pestun)
 * [sertop]  Set default value of allow-sprop to be true in agreement with upstream coq v8.11
             and added option '--disallow-sprop' to optionally switch it off
			 (--disallow-sprop forbids using the proof irrelevant SProp sort)
             (@pestun , ejgallego/coq-serapi#199)
 * [sertop]  Added option `--topfile` to `sertop` to set top name from
             a filename (ejgallego/coq-serapi#197, @pestun)
 * [deps]    Require sexplib >= 0.12 , fixed deprecation warnings
             (ejgallego/coq-serapi#194, @ejgallego)
 * [general] SerAPI is now tested with OCaml 4.08 and 4.09 (ejgallego/coq-serapi#195 , @ejgallego)
 * [sertop ] Forward port sername from 0.7.1 (@ejgallego)
 * [serlib ] Fix ejgallego/coq-serapi#212 "Segfault on universes" (@ejgallego, reported by @cpitclaudel , ejgallego/coq-serapi#214)
 * [serapi ] Fix ejgallego/coq-serapi#221 "Support COQPATH" (@ejgallego, reported by @cpitclaudel , ejgallego/coq-serapi#224)
 * [sertop ] Fix ejgallego/coq-serapi#222 "Support --indices-matter" (@ejgallego, reported by @cpitclaudel , ejgallego/coq-serapi#223)
 * [sertop ] Fix "Stack overflow in main loop" (@pestun , ejgallego/coq-serapi#216)
ejgallego added a commit to ejgallego/opam-repository that referenced this issue Aug 27, 2020
CHANGES:

* [general] Require dune >= 2.0 (@ejgallego, ??)
 * [serapi]  New query `Comments` to return all comments in a document
             (@ejgallego, ejgallego/coq-serapi#20? , (partially) fixes ejgallego/coq-serapi#191 , ejgallego/coq-serapi#200 )
 * [general] Coq's error recovery is now disabled by default
             (@ejgallego , fixes ejgallego/coq-serapi#201)
 * [general] New option `--error-recovery` to enable error recovery
             (@ejgallego , ejgallego/coq-serapi#203)
 * [general] Bump sexplib dependency to v0.13 (@ejgallego , ejgallego/coq-serapi#204)
             Fixes incorrect change in ejgallego/coq-serapi#194.
 * [sertop]  Set default value of allow-sprop to be true in agreement with upstream coq v8.11
             and added option '--disallow-sprop' to optionally switch it off
			 (--disallow-sprop forbids using the proof irrelevant SProp sort)
             (ejgallego/coq-serapi#199, @pestun)
 * [sertop]  Set default value of allow-sprop to be true in agreement with upstream coq v8.11
             and added option '--disallow-sprop' to optionally switch it off
			 (--disallow-sprop forbids using the proof irrelevant SProp sort)
             (@pestun , ejgallego/coq-serapi#199)
 * [sertop]  Added option `--topfile` to `sertop` to set top name from
             a filename (ejgallego/coq-serapi#197, @pestun)
 * [deps]    Require sexplib >= 0.12 , fixed deprecation warnings
             (ejgallego/coq-serapi#194, @ejgallego)
 * [general] SerAPI is now tested with OCaml 4.08 and 4.09 (ejgallego/coq-serapi#195 , @ejgallego)
 * [sertop ] Forward port sername from 0.7.1 (@ejgallego)
 * [serlib ] Fix ejgallego/coq-serapi#212 "Segfault on universes" (@ejgallego, reported by @cpitclaudel , ejgallego/coq-serapi#214)
 * [serapi ] Fix ejgallego/coq-serapi#221 "Support COQPATH" (@ejgallego, reported by @cpitclaudel , ejgallego/coq-serapi#224)
 * [sertop ] Fix ejgallego/coq-serapi#222 "Support --indices-matter" (@ejgallego, reported by @cpitclaudel , ejgallego/coq-serapi#223)
 * [sertop ] Fix "Stack overflow in main loop" (@pestun , ejgallego/coq-serapi#216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants