[serapi] Add document creation NewDoc protocol call.
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
v8.9+newdoc
branch
2 times, most recently
from
14e23c4
to
ca09615
Compare
ejgallego
force-pushed
the
v8.9+newdoc
branch
2 times, most recently
from
3279ddc
to
ba9fd5b
Compare
ejgallego
force-pushed
the
v8.9+newdoc
branch
from
ba9fd5b
to
31be390
Compare
ejgallego
force-pushed
the
v8.9+newdoc
branch
from
31be390
to
79676d1
Compare
ejgallego
force-pushed
the
v8.9+newdoc
branch
from
79676d1
to
fac61f4
Compare
|
This is ready, will merge soon. |
The protocol now supports a method:
```
(NewDoc ((top_name "Module")
(iload_path (path_1 ... path_n)
(require_libs (require_1 ... require_n))))
```
where `path_i` is of type
```
Mltop.coq_path = {
path_spec: coq_path_spec;
recursive: bool;
}
type coq_path_spec =
| VoPath of vo_path_spec
| MlPath of string
type vo_path_spec = {
unix_path : string;
coq_path : Names.DirPath.t;
implicit : bool;
has_ml : add_ml;
}
```
and `require_i` is of type:
```
string * string option * bool option
```
where `(module, root, import)` corresponds to `From root Require import module`
`iload_path` and `require_libs` are optional, if absent, SerAPI will
resort to the defaults.
By default, invoking `sertop` will create a document with the standard
paths and `Prelude` loaded. To avoid that, use the commit line option
`--no_init`. **Important** in practice the user still can only use
this option to create one single document using `NewDoc`, as the
protocol doesn't yet include per-document addressing.
This PR improves a certain number of things, including `compser` and
`sercomp` will now create documents with the proper module path cc: #84.
This also improves #49 and #59.
ejgallego
force-pushed
the
v8.9+newdoc
branch
from
fac61f4
to
49545fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol now supports a method:
(NewDoc ((top_name "Module") (iload_path (path_1 ... path_n) (require_libs (require_1 ... require_n))))where
path_iis of typeand
require_iis of type:where
(module, root, import)corresponds toFrom root Require import moduleiload_pathandrequire_libsare optional, if absent, SerAPI willresort to the defaults.
By default, invoking
sertopwill create a document with the standardpaths and
Preludeloaded. To avoid that, use the commit line option--no_init.Important in practice the user still can only use
this option to create one single document using
NewDoc, as theprotocol doesn't yet include per-document addressing.
This PR improves a certain number of things, including
compserandsercompwill now create documents with the proper module path cc: #84.This also improves #49 and #59.