Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading recurive dirs #65

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix reading recurive dirs #65

merged 1 commit into from
Aug 28, 2023

Conversation

rfun
Copy link
Contributor

@rfun rfun commented Aug 24, 2023

No description provided.

@ejhayes
Copy link
Owner

ejhayes commented Aug 25, 2023

Thanks for adding this in @rfun. As long as tests pass this should be good to merge in

@rfun
Copy link
Contributor Author

rfun commented Aug 28, 2023

Tests pass locally :

image

However, the functions relating to ReadDir are not being covered in the tests. Opening an issue : #68

@ejhayes ejhayes added bug Something isn't working patch Increment the patch version when merged labels Aug 28, 2023
@ejhayes ejhayes linked an issue Aug 28, 2023 that may be closed by this pull request
Add Tests for ReadDir #68
Open
@ejhayes ejhayes removed a link to an issue Aug 28, 2023
Add Tests for ReadDir #68
Open
@ejhayes ejhayes merged commit 2d46a31 into ejhayes:next Aug 28, 2023
1 check passed
@github-actions github-actions bot added the prerelease This change is available in a prerelease. label Oct 25, 2023
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Merged
@ejhayes ejhayes linked an issue Oct 25, 2023 that may be closed by this pull request
Add Tests for ReadDir #68
Open
@ejhayes ejhayes mentioned this pull request Nov 1, 2023
Merged
@ejhayes
Copy link
Owner

ejhayes commented Nov 1, 2023

Changes from this PR have been pulled out in favor of #105

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Nov 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

🚀 Issue was released in v0.1.4 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhayes ejhayes ejhayes approved these changes

Assignees
No one assigned
Labels
bug Something isn't working patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Tests for ReadDir
2 participants
@rfun @ejhayes