Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for ReadDir #68

Open
rfun opened this issue Aug 28, 2023 · 1 comment · Fixed by #65
Open

Add Tests for ReadDir #68

rfun opened this issue Aug 28, 2023 · 1 comment · Fixed by #65

Comments

@rfun
Copy link
Contributor

rfun commented Aug 28, 2023

Need to add tests around the getChartDirs method to ensure that readDir is behaving as expected, even in recursive scenarios.

@ejhayes ejhayes linked a pull request Aug 28, 2023 that will close this issue
@ejhayes ejhayes removed a link to a pull request Aug 28, 2023
@ejhayes ejhayes linked a pull request Oct 25, 2023 that will close this issue
@ejhayes
Copy link
Owner

ejhayes commented Oct 25, 2023

This is pushed out to 0.1.4-next.0. Assuming that looks good this fix should be in 0.1.4 moving forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants