Use checked_mul instead of raw multiplication. Fixes #11

ejmahler · Feb 20, 2024 · c4bcd39 · c4bcd39
1 parent e70dd15
commit c4bcd39
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/in_place.rs b/src/in_place.rs
@@ -67,7 +67,7 @@ fn multiplicative_inverse(a: usize, n: usize) -> usize {
 /// 
 /// Panics if `input.len() != input_width * input_height` or if `output.len() != input_width * input_height`
 pub fn transpose_inplace<T: Copy>(buffer: &mut [T], scratch: &mut [T], width: usize, height: usize) {
-	assert_eq!(width*height, buffer.len());
+	assert_eq!(width.checked_mul(height), Some(buffer.len()));
 	assert_eq!(core::cmp::max(width, height), scratch.len());
 
 	let gcd = StrengthReducedUsize::new(num_integer::gcd(width, height));

diff --git a/src/out_of_place.rs b/src/out_of_place.rs
@@ -228,8 +228,8 @@ fn transpose_recursive<T: Copy>(input: &[T], output: &mut [T], row_start: usize,
 /// 
 /// Panics if `input.len() != input_width * input_height` or if `output.len() != input_width * input_height`
 pub fn transpose<T: Copy>(input: &[T], output: &mut [T], input_width: usize, input_height: usize) {
-    assert_eq!(input_width*input_height, input.len());
-    assert_eq!(input_width*input_height, output.len());
+    assert_eq!(input_width.checked_mul(input_height), Some(input.len()));
+    assert_eq!(input.len(), output.len());
     if input.len() <= SMALL_LEN {
         unsafe { transpose_small(input, output, input_width, input_height) };
     }