Skip to content

Commit

Permalink
Reformat PR comment messages
Browse files Browse the repository at this point in the history
Probably a matter of personal taste, but making it into a
full sentence looks nicer in comments.

commit-id:bdba0972
  • Loading branch information
leoluk committed Dec 18, 2021
1 parent af1225c commit 4e24da4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions spr/spr.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (sd *stackediff) UpdatePullRequests(ctx context.Context) {
}
for _, pr := range githubInfo.PullRequests {
if _, found := localCommitMap[pr.Commit.CommitID]; !found {
sd.github.CommentPullRequest(ctx, pr, "closing pull request : commit has gone away")
sd.github.CommentPullRequest(ctx, pr, "Closing pull request: commit has gone away")
sd.github.ClosePullRequest(ctx, pr)
} else {
validPullRequests = append(validPullRequests, pr)
Expand Down Expand Up @@ -219,7 +219,7 @@ func (sd *stackediff) MergePullRequests(ctx context.Context) {
for i := 0; i < prIndex; i++ {
pr := githubInfo.PullRequests[i]
comment := fmt.Sprintf(
"commit MERGED in pull request [#%d](https://%s/%s/%s/pull/%d)",
"✓ Commit merged in pull request [#%d](https://%s/%s/%s/pull/%d)",
prToMerge.Number, sd.config.Repo.GitHubHost, sd.config.Repo.GitHubRepoOwner, sd.config.Repo.GitHubRepoName, prToMerge.Number)
sd.github.CommentPullRequest(ctx, pr, comment)
sd.github.ClosePullRequest(ctx, pr)
Expand Down

0 comments on commit 4e24da4

Please sign in to comment.