Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plot and predict methods #17

Closed
ejolly opened this issue Oct 22, 2017 · 1 comment
Closed

Refactor plot and predict methods #17

ejolly opened this issue Oct 22, 2017 · 1 comment

Comments

@ejolly
Copy link
Owner

ejolly commented Oct 22, 2017

Right now model.plot() essentially makes predictions using it's own internal data. Predict does the same, but just using population level parameters and R's predict() function which conveniently can handle rfx scaling.

Refactor so that predict can take in new data, or use it's own data (i.e. when it's called via plot). Also add flag that it can make group level predictions using group level parameter fits.

@ejolly
Copy link
Owner Author

ejolly commented Mar 3, 2018

This doesnt actually make sense because plot is making marginal predictions not full predictions given all fitted coefficients. Makes sense to keep them separate.

@ejolly ejolly closed this as completed Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant