Prevent XSS by escaping potential HTML #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for doing these. Sorry to bug you about one more thing. The whitespace changes in this commit to the SQL generation method have caused a conflict. I started to resolve it, but it is a little more complicated than totally trivial :) so I don't want to mess it up, and I'm wondering if you could resolve the conflict? I don't know what your preferred workflow is, but what I usually do is a interactive rebase, and then force push to the branch to overwrite the commit with the new one. |
|
No sweat! Have updated the branch… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escapes potential HTML content by adding a
hhelper method and using it in the views whenever text output from the DB is rendered into a view.Closes #49