Cleanup gemspec and add release instructions #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gem.version = "1.2.6" | ||
| gem.author = "Erick Schmitt" | ||
| gem.email = "ejschmitt@gmail.com" | ||
| gem.homepage = "http://github.com/toolmantim/user_agent_parser" |
There was a problem hiding this comment.
Hah, yes! Sorry about that. Will fix tomorrow.
On Sun, Mar 9, 2014 at 3:24 PM, Andy Atkinson notifications@github.com
wrote:
@@ -1,55 +1,31 @@
-# -- encoding: utf-8 --
+Gem::Specification.new do |gem|
- gem.name = "delayed_job_web"
- gem.version = "1.2.6"
- gem.author = "Erick Schmitt"
- gem.email = "ejschmitt@gmail.com"
- gem.homepage = "http://github.com/toolmantim/user_agent_parser"
This is a typo?
Reply to this email directly or view it on GitHub:
https://github.com/ejschmitt/delayed_job_web/pull/58/files#r10412626
toolmantim
referenced
this pull request
Mar 10, 2014
|
I see, I didn't notice the date thing, nice catch. |
andyatkinson
added a commit
that referenced
this pull request
Mar 11, 2014
…se-instructions Cleanup gemspec and add release instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make things a bit more friendly for contributions / adding contributors.
Also fixes the multiple gem versions with the same date thing… as it will just use
Date.today